Sahina Bose has posted comments on this change.
Change subject: gluster: BLL Cmd for stop remove brick async task
......................................................................
Patch Set 2:
(2 comments)
Missing AppErrors.properties, LocalizedEnums.java, LocalizedEnums.properties,
AuditLogMessages.properties (I may have missed some)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java
Line 57: VDSReturnValue returnValue =
Line 58:
runVdsCommand(VDSCommandType.StopRemoveGlusterVolumeBricks,
Line 59: new
GlusterVolumeRemoveBricksVDSParameters(getUpServer().getId(),
Line 60: volume.getName(),
Line 61: volume.getBricks(),
Shouldn't the bricks be from the parameters class?
Line 62: volume.getReplicaCount()));
Line 63: setSucceeded(returnValue.getSucceeded());
Line 64: if (!getSucceeded()) {
Line 65:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REMOVE_BRICKS_FAILED,
returnValue.getVdsError().getMessage());
Line 58:
runVdsCommand(VDSCommandType.StopRemoveGlusterVolumeBricks,
Line 59: new
GlusterVolumeRemoveBricksVDSParameters(getUpServer().getId(),
Line 60: volume.getName(),
Line 61: volume.getBricks(),
Line 62: volume.getReplicaCount()));
replicaCount - it cannot be the volume's replica count. But again, replica
count should not be required for Stop.
Line 63: setSucceeded(returnValue.getSucceeded());
Line 64: if (!getSucceeded()) {
Line 65:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REMOVE_BRICKS_FAILED,
returnValue.getVdsError().getMessage());
Line 66: return;
--
To view, visit http://gerrit.ovirt.org/19051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f54aa86bcc8ceb10fd2925a6e1fce8e905b6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
