Allon Mureinik has posted comments on this change.

Change subject: core: permission filtering for GetVdsInterfacesByVdsId
......................................................................


Patch Set 3: (1 inline comment)

Basically looks good, but unit tests are required.

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java
Line 124: 
Why is unchecked needed here?

--
To view, visit http://gerrit.ovirt.org/2964
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice3e9c4212447e9bc2a3ae57e1eb5621ebd497df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to