Maor Lipchuk has posted comments on this change. Change subject: core: Fix Test of Vm handler. ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java Line 75: assertEquals(suggestedDiskAlias, "VM_TEST_NAME_Disk2"); I think test results should not be extracted to constants since it is not reused for other test, is is very specific, and it will make the class propegated with too many constants. -- To view, visit http://gerrit.ovirt.org/3557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib68b0c6143cac08a65260c97504ee38642c1aaca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
