Alexander Wels has posted comments on this change. Change subject: webadmin: unescape cell tooltips string values ......................................................................
Patch Set 2: htmlEscapeAllowEntities escapes only unescaped strings. And does NOT double escape strings. I am concerned that we are not escaping strings at all, but then again we are passing in SafeHtml objects which should be safe (hence the name). -- To view, visit http://gerrit.ovirt.org/19018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2da6812694737c212352afda48fa9a50e97f8d60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
