Kanagaraj M has posted comments on this change.

Change subject: engine: Gluster task monitoring for tasks started from CLI
......................................................................


Patch Set 1:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 91: 
Line 92:                     @Override
Line 93:                     public Void runInTransaction() {
Line 94:                         createJobToMonitor(task);
Line 95:                         return null;
why do you need to return?
Line 96:                     }
Line 97:                 });
Line 98:             }
Line 99:             //update status in step table


Line 125:         StepEnum step = task.getType().getStep();
Line 126:         VdcActionType actionType;
Line 127:         switch (step) {
Line 128:         case REBALANCING_VOLUME:
Line 129:             actionType = VdcActionType.StartRebalanceGlusterVolume;
break; is required here
Line 130:         default:
Line 131:             actionType = VdcActionType.Unknown;
Line 132:         }
Line 133: 


-- 
To view, visit http://gerrit.ovirt.org/19183
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6385cbcad988351f23bda2294c8e85dde54560
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to