Sahina Bose has posted comments on this change.
Change subject: engine: Introduced InternalJob and InternalStep command
......................................................................
Patch Set 1:
(2 comments)
Updated patchset to follow
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java
Line 19: @Override
Line 20: protected boolean canDoAction() {
Line 21: boolean retValue=super.canDoAction();
Line 22:
Line 23: if (job != null) {
Not sure I understand, but external step can be created only if job is
external. This is not true for InternalStep.
Line 24: if (!job.isExternal()) {
Line 25: retValue = false;
Line 26:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_NOT_EXTERNAL);
Line 27: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java
Line 49: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 50: List<PermissionSubject> permissionList = new
ArrayList<PermissionSubject>();
Line 51: permissionList.add(new
PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID,
Line 52: VdcObjectType.System,
Line 53: ActionGroup.INJECT_EXTERNAL_TASKS));
I'm changing this to check that user has permissions on the actionType passed.
Updated patchset to follow
Line 54: return permissionList;
Line 55: }
--
To view, visit http://gerrit.ovirt.org/19182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17074d4317c037fa9fcc680f4b0a7a9b3a6b087a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
