Alon Bar-Lev has posted comments on this change.

Change subject: restapi: Deploy as independent .war
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/conf/engine.conf.defaults.in
Line 107: # application server started by the engine. This is a list of space
Line 108: # separated files or directories that should exist under
Line 109: # /usr/share/ovirt-engine:
Line 110: #
Line 111: ENGINE_APPS="engine.ear restapi.war"
Oh... I see abs: http://gerrit.ovirt.org/#/c/13796, you chose to use full path, 
maybe better to place it earlier in queue, not that important.

I still think that ENGINE_WARS as a base for our provided wars will reduce the 
complexity of the spec and Makefile.
Line 112: 
Line 113: #
Line 114: # Flags to enable or disable the web server (the proxy) and the
Line 115: # connectors of the application server:


-- 
To view, visit http://gerrit.ovirt.org/13718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11558b95f3c99cad2edc2d42170fce7eb88c005b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to