Michael Pasternak has posted comments on this change. Change subject: cli: Correct ordering of fields for "list bricks" with all-content as true(#990009) ......................................................................
Patch Set 2: Code-Review-1 (1 comment) .................................................... File src/ovirtcli/format/text.py Line 152: # Ordering the fields for listing brick memory detail Line 153: if isinstance(resource,params.GlusterMemoryPool): Line 154: sort_strategy = ['id','name', 'hot_count','cold_count', Line 155: 'padded_size','alloc_count','max_alloc', Line 156: 'pool_misses','max_stdalloc','description'] why would you like sorting these attributes? doing that will mean maintaining cli, i.e upon server changes, cli has to be addressed as well, while up until now, cli was completely generic & agnostic to server implementation. Line 157: fields = self.sort_fields(self._get_fields(resource), sort_strategy) Line 158: width0 = width Line 159: Line 160: if width0 == -1: -- To view, visit http://gerrit.ovirt.org/19203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I974bde6937992b391f01accd7977b9dc0e5a5ef7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: ndarshan <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: ndarshan <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
