Lior Vernia has posted comments on this change.
Change subject: webadmin: fix QoS dialog indentation
......................................................................
Patch Set 4:
(3 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java
Line 112: setStyle();
Line 113: }
Line 114:
Line 115: private void setStyle() {
Line 116:
inboundAverageEditor.setContentWidgetStyleName(style.valueWidth());
If you follow the below comment, I think you could just set the style of the
widget itself rather than look for the content widget, and if so it could be
done in the CSS.
Line 117:
inboundAverageEditor.setLabelStyleName(style.hideLabelStyle());
Line 118:
inboundPeakEditor.setContentWidgetStyleName(style.valueWidth());
Line 119: inboundPeakEditor.setLabelStyleName(style.hideLabelStyle());
Line 120:
inboundBurstEditor.setContentWidgetStyleName(style.valueWidth());
Line 113: }
Line 114:
Line 115: private void setStyle() {
Line 116:
inboundAverageEditor.setContentWidgetStyleName(style.valueWidth());
Line 117:
inboundAverageEditor.setLabelStyleName(style.hideLabelStyle());
Instead of using EntityModelTextBoxEditor and manually hiding the labels for
each of the six editors, you could use EntityModelTextBoxOnlyEditor.
Line 118:
inboundPeakEditor.setContentWidgetStyleName(style.valueWidth());
Line 119: inboundPeakEditor.setLabelStyleName(style.hideLabelStyle());
Line 120:
inboundBurstEditor.setContentWidgetStyleName(style.valueWidth());
Line 121: inboundBurstEditor.setLabelStyleName(style.hideLabelStyle());
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml
Line 38: </ui:style>
Line 39:
Line 40: <d:SimpleDialogPanel width="400px" height="400px">
Line 41: <d:content>
Line 42: <g:FlowPanel>
Looks like there's a trailing space here.
Line 43: <g:FlowPanel
addStyleNames="{style.topDecorator}">
Line 44: <e:ListModelListBoxEditor
ui:field="dataCenterEditor" />
Line 45: <e:EntityModelTextBoxEditor
ui:field="nameEditor" />
Line 46: </g:FlowPanel>
--
To view, visit http://gerrit.ovirt.org/19356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
