Michael Pasternak has posted comments on this change.

Change subject: restapi: Start VM not as RunOnce
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 228:                             new VM()),
Line 229:                             new RunVmOnceParams(guid));
Line 230:             if (action.isSetVm()) {
Line 231:                 validateEnums(VM.class, action.getVm());
Line 232:                 VM vm = action.getVm();
no, vm will serve as a template, see:

VmMapper#map(org.ovirt.engine.core.common.businessentities.VM entity, VM 
template)
Line 233:                 params = map(vm, params);
Line 234:                 if (vm.isSetPlacementPolicy() && 
vm.getPlacementPolicy().isSetHost()) {
Line 235:                     validateParameters(vm.getPlacementPolicy(), 
"host.id|name");
Line 236:                     
params.setDestinationVdsId(getHostId(vm.getPlacementPolicy().getHost()));


-- 
To view, visit http://gerrit.ovirt.org/19267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40be200c8742d8b31b7881926c59deaf345992ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to