Michael Kublin has posted comments on this change.
Change subject: core: add hotplug support when adding VM nic
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
Line 21: private VmDevice vmDevice;
Make getter at parent class it is better, also we don't need internal variable
which is points on singelton
Line 36: }
should be returnValue && vmDevice == null
Line 46: protected void Perform() {
These check is useless.
Code at VmOperationCommandBase:
@Override
protected void ExecuteVmCommand() {
if (GetRunningOnVds()) { <-- It is means that the code will not run
if vm is not up , the
plug/unplug will not work
when vm is down. It is look
like
that inheritance tree is wrong.
Perform();
return;
}
setActionReturnValue((getVm() != null) ? getVm().getstatus() :
VMStatus.Down);
}
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/PlugAction.java
Line 4:
It is boolean, why we need additional enum which points on two value, boolean
is enought
--
To view, visit http://gerrit.ovirt.org/3453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64adbc2ab0f30a3ba532ddd8cc5986528b4b079b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
