Tal Nisan has uploaded a new change for review. Change subject: engine: Fix NPE in UpdateVdsGroupCommand ......................................................................
engine: Fix NPE in UpdateVdsGroupCommand Fixed an NPE when updating a cluster Change-Id: Ibc2fd532e4955d9c2d4632ad8d5c2f47b6615838 Bug-Url: https://bugzilla.redhat.com/1011435 Signed-off-by: Tal Nisan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/19523/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java index 483eafc..8b871ca 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java @@ -59,7 +59,7 @@ String emulatedMachine = null; // pick an UP host randomly - all should have latest compat version already if we passed the canDo. for (VDS vds : allForVdsGroup) { - if (getVds().getStatus() == VDSStatus.Up) { + if (vds.getStatus() == VDSStatus.Up) { emulatedMachine = ListUtils.firstMatch( Config.<List<String>>GetValue(ConfigValues.ClusterEmulatedMachines, getParameters().getVdsGroup().getcompatibility_version().getValue()), vds.getSupportedEmulatedMachines().split(",")); -- To view, visit http://gerrit.ovirt.org/19523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc2fd532e4955d9c2d4632ad8d5c2f47b6615838 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
