Sahina Bose has posted comments on this change.
Change subject: engine:BLL Command modified to return status after rebalance
stop
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 64:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REBALANCE_STOP_FAILED,
vdsReturnaValue.getVdsError()
Line 65: .getMessage());
Line 66: return;
Line 67: }
Line 68: else {
The status VDS command should not be called from within Stop command, IMO.
If UI needs to show the status on stop, UI layer should call status bll command
after stop command.
Line 69: // Run the VDSM verb to get the status
Line 70: VDSReturnValue vdsRettunValueStatus =
Line 71:
runVdsCommand(VDSCommandType.GetGlusterVolumeRebalanceStatus,
Line 72: new
GlusterVolumeVDSParameters(upServer.getId(), getGlusterVolumeName()));
--
To view, visit http://gerrit.ovirt.org/19585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica92511e4898e2119eec312854f390a22152e212
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
