Allon Mureinik has posted comments on this change.
Change subject: engine: Disk interface validation
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Looks good to me (see some minor nits inline - may be worth fixing when you
rebase).
Giving +1 so that other reviewers have the chance to take a look too.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java
Line 31: getParameters().getVmId(),
Line 32: getUserID(),
Line 33: getParameters().isFiltered());
Line 34:
Line 35: if (diskList == null || diskList.isEmpty()) {
diskList is guaranteed to be not null - i'd remove the null check when if you
rebase this patch.
Line 36: setReturnValue(Collections.emptyList());
Line 37: return;
Line 38: }
Line 39:
Line 36: setReturnValue(Collections.emptyList());
Line 37: return;
Line 38: }
Line 39:
Line 40: ArrayList<Disk> filteredDiskList = new ArrayList<Disk>();
Sorry for missing this in the previous round - should this be defined as List
instead of ArrayList?
Line 41:
Line 42: VM vm =
DbFacade.getInstance().getVmDao().get(getParameters().getVmId(),
Line 43: getUserID(),
Line 44: getParameters().isFiltered());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
Line 24: */
Line 25: public class DiskValidator {
Line 26:
Line 27: private Disk disk;
Line 28: protected static final Log LOG =
LogFactory.getLog(DiskValidator.class);
should be private
Line 29:
Line 30: public DiskValidator(Disk disk) {
Line 31: this.disk = disk;
Line 32: }
--
To view, visit http://gerrit.ovirt.org/18648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
