Cheryn Tan has posted comments on this change.
Change subject: core: prevent disabling VirtIO-SCSI on edit VM
......................................................................
Patch Set 1:
(1 comment)
Minor change for the error message.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 860: DISK_IS_ALREADY_SHARED_BETWEEN_VMS=Cannot ${action} ${type}. Disk is
shared between vms and cannot become unshareable . Detach the disk from the
rest of the vms it is attached to and then update the disk to be unshareable.
Line 861: SCSI_GENERIC_IO_IS_NOT_SUPPORTED_FOR_IMAGE_DISK="Cannot ${action}
${type}. SCSI Generic IO is not supported for image disk."
Line 862: VIRTIO_SCSI_INTERFACE_IS_NOT_AVAILABLE_FOR_CLUSTER_LEVEL=Virtio-SCSI
interface is only available on cluster level 3.3 or higher.
Line 863: CANNOT_PERFORM_ACTION_VIRTIO_SCSI_IS_DISABLED=Cannot ${action}
${type}. VirtIO-SCSI is disabled for the VM
Line 864: CANNOT_DISABLE_VIRTIO_SCSI_PLUGGED_DISKS=Cannot disable VirtIO-SCSI
while disks that attached with VirtIO-SCSI interface are plugged to the VM.
Minor nitpick, suggest changing to:
"Cannot disable VirtIO-SCSI when disks with a VirtIO-SCSI interface are plugged
into the VM."
Line 865:
Line 866: #Suspected (not in use?)
Line 867: USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please
change your password.
Line 868: USER_CANNOT_LOGIN_DOMAIN_NOT_SUPPORTED=Cannot Login. The Domain
provided is not configured, please contact your system administrator.
--
To view, visit http://gerrit.ovirt.org/19637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
