Kanagaraj M has posted comments on this change.
Change subject: gluster: fix import cluster when one of the peers is unreachable
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java
Line 45: USER,
Line 46: getParameters().getPassword(),
Line 47: getParameters().getFingerprint());
Line 48:
Line 49: // Keep server details in the map only for the servers
which are reachable
Map is not Iterable.
It could lead ConcurrentModificationException if you try to remove an element
from the same collection when iterating.
Line 50: Iterator<Map.Entry<String, String>> iterator =
serverFingerPrintMap.entrySet().iterator();
Line 51: while (iterator.hasNext()) {
Line 52: Map.Entry<String,String> entry = iterator.next();
Line 53: if (entry.getValue() == null) {
--
To view, visit http://gerrit.ovirt.org/19614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e31006072ebf771ce49a73238a4fb933a6269f7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
