Tal Nisan has posted comments on this change.
Change subject: core: use private access modifier and rename method.
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1105: AuditLogDirector.log(logable,
Line 1106: AuditLogType.VDS_DOMAIN_DELAY_INTERVAL);
Line 1107: }
Line 1108:
Line 1109: private List<Guid>
getDomainsReportedAsProblematic(List<VDSDomainsData> vdsDomainsData) {
s/get/obtain, get sounds like a getter, might be confusing
Line 1110: List<Guid> domainsInProblem = new LinkedList<>();
Line 1111: Set<Guid> domainsInPool = new HashSet<Guid>(
Line 1112:
DbFacade.getInstance().getStorageDomainStaticDao().getAllIds(
Line 1113: _storagePoolId,
StorageDomainStatus.Active));
--
To view, visit http://gerrit.ovirt.org/19662
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fb4aff4a6ad6f4f83f21b148d2f1df3ce6efaf2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
