Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: stop and warn if setup is not run as root 
user.
......................................................................


Patch Set 1:

(1 comment)

....................................................
File packaging/ovirt-engine-reports-setup.py
Line 74: DIR_TEMP_SCHEDUALE=tempfile.mkdtemp()
Line 75: 
Line 76: def _verifyUserPermissions():
Line 77:     username = pwd.getpwuid(os.getuid())[0]
Line 78:     if os.geteuid() != 0:
Don't you want to log this?
Line 79:         sys.exit(
Line 80:             'Error: insufficient permissions for user {user}, '
Line 81:             'you must run with user root.'.format(
Line 82:                 user=username


-- 
To view, visit http://gerrit.ovirt.org/18755
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to