Ori Liel has submitted this change and it was merged. Change subject: resatpi: Eliminate Exceptions in Mapper Tests ......................................................................
resatpi: Eliminate Exceptions in Mapper Tests Up until now, mapper tests silently ignored several failures to instantiated new objects using reflection. There were two types of problems: - Instantiation of objects with no empty constructor (namely XMLGregorianCalendar) - Mismatch between plural and singular entity name, e.g: 'Floppies.java' vs 'Floppy.java' (differenct than truncating the suffix 's') All exceptional cases have been handled in this patch, and all methods that had a try/catch clause, which swallowed the exception, were made to 'throw' the exception onward instead. Change-Id: I84cabed0ff38196d8fd57d2f72ffdfe213f2ffed Signed-off-by: Ori Liel <[email protected]> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterBrickDetailMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 3 files changed, 105 insertions(+), 79 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84cabed0ff38196d8fd57d2f72ffdfe213f2ffed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
