Leonardo Bianconi has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 37: private InitializationType initializationType;
Line 38:
Line 39: private Map<VmDevice, Map<String, String>>
runtimeDeviceCustomProperties;
Line 40:
Line 41: private ArchitectureType architecture;
Done
Line 42:
Line 43: public String getUserDefinedProperties() {
Line 44: return vmStatic.getUserDefinedProperties();
Line 45: }
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 46:
_vmTemplate.setOsId(osRepository.getOsIdByUniqueName(node.InnerText));
Line 47: }
Line 48:
Line 49: // Workaround until the support for OVF on POWER is implemented
Line 50: _vmTemplate.setArchitecture(ArchitectureType.x86_64);
Omer, a question here, do you mean "documenting" as write it in a comment in
the file or find a field to write the architecture?
Just to clarify, we are setting the architecture hard-coded for x86_64, untill
we have the OS for power and the validations when creating Template/VM. So this
code will change in another patch to get the architecture from the OS and set
it for the template.
Line 51: }
Line 52:
Line 53: @Override
Line 54: protected void readHardwareSection(XmlNode section) {
--
To view, visit http://gerrit.ovirt.org/18938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecd642e2bc05067d55884c948bdaeb6e7838c26
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
