Alon Bar-Lev has posted comments on this change.
Change subject: core: Adds dependency list generation
......................................................................
Patch Set 1:
(5 comments)
....................................................
File Makefile
Line 103: BUILD_FLAGS:=$(BUILD_FLAGS) -D skipTests
Line 104: endif
Line 105: ifeq ($(BUILD_DL),0)
Line 106: BUILD_FLAGS:=$(BUILD_FLAGS) -D skipDependencyList
Line 107: endif
yes.
Line 108: ifneq ($(BUILD_DEV),0)
Line 109: BUILD_FLAGS:=$(BUILD_FLAGS) $(DEV_BUILD_FLAGS)
Line 110: endif
Line 111: BUILD_FLAGS:=$(BUILD_FLAGS) $(EXTRA_BUILD_FLAGS)
....................................................
File pom.xml
Line 694: </profile>
Line 695: <profile>
Line 696: <id>list-dependencies</id>
Line 697: <activation>
Line 698: <property><name>!skipDependencyList</name></property>
Yes... but why be negative? why not ovirt.generateDependencyList ?
Line 699: </activation>
Line 700: <build>
Line 701: <plugins>
Line 702: <plugin>
Line 709: <goals>
Line 710: <goal>resolve</goal>
Line 711: </goals>
Line 712: <configuration>
Line 713:
<outputFile>${session.executionRootDirectory}/target/dependencies.txt</outputFile>
I think that we should produce dependencies for each artifact, so we can know
what dependency we have for each.
Please remember that we are interested mainly in gwt artifacts converted to
javascript, so these are in common and frontend.
For build time dependencies, you should somehow determine what is used for
build and not runtime.
Runtime is not interested as we get them at rpm.
Line 714: <appendOutput>true</appendOutput>
Line 715: </configuration>
Line 716: </execution>
Line 717: </executions>
Line 710: <goal>resolve</goal>
Line 711: </goals>
Line 712: <configuration>
Line 713:
<outputFile>${session.executionRootDirectory}/target/dependencies.txt</outputFile>
Line 714: <appendOutput>true</appendOutput>
So generate per target and collect.
Line 715: </configuration>
Line 716: </execution>
Line 717: </executions>
Line 718: </plugin>
Line 711: </goals>
Line 712: <configuration>
Line 713:
<outputFile>${session.executionRootDirectory}/target/dependencies.txt</outputFile>
Line 714: <appendOutput>true</appendOutput>
Line 715: </configuration>
I do not care what we have now...
Line 716: </execution>
Line 717: </executions>
Line 718: </plugin>
Line 719: </plugins>
--
To view, visit http://gerrit.ovirt.org/19785
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78d7facefe4e4fc6bb3144b5b658dcfc5e412ed1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
