Mike Kolesnik has posted comments on this change.
Change subject: core: permission filtering for getAllForVdsGroup
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File backend/manager/dbscripts/vds_sp.sql
Line 763: FROM
user_vds_groups_permissions_view
Should'nt you be checking the VDS permissions here, since this is what's
returned?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsByClusterIdParameters.java
Line 8: public GetHostsByClusterIdParameters() {
Why is this empty ctor needed?
Line 15: private Guid _id = new Guid();
Please don't use underscore in field names.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java
Line 278: assertTrue(result.size() == 0);
Can you use isEmpty()?
Line 290: private void assertCorrectResult(List<VDS> result) {
Please use more specific name.
Line 292: assertTrue(result.size() > 0);
Can you use ! isEmtpy()?
Line 293: assertEquals(result.iterator().next(), existingVds);
Better check that all entities have same cluster id as requested..
--
To view, visit http://gerrit.ovirt.org/3543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb27c75bed6c824bf367a8244a4c6163307bb64e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
