Gilad Chaplik has posted comments on this change.
Change subject: webadmin: action to commit brick removal operation
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
minor comments
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 845: GlusterVolumeEntity volumeEntity = (GlusterVolumeEntity)
getEntity();
Line 846: ArrayList<String> list = new ArrayList<String>();
Line 847: for (GlusterBrickEntity brick : volumeEntity.getBricks()) {
Line 848: if (brick.getAsyncTask() != null &&
brick.getAsyncTask().getStatus() == JobExecutionStatus.STARTED) {
Line 849: list.add(brick.getQualifiedName());
[*]
Line 850: }
Line 851: }
Line 852: model.setItems(list);
Line 853:
Line 870: ConfirmationModel model = (ConfirmationModel)
getConfirmWindow();
Line 871:
Line 872: if (model.getProgress() != null) {
Line 873: return;
Line 874: }
same q, why the progress check.
Line 875:
Line 876: if (getSelectedItems() == null ||
getSelectedItems().isEmpty()) {
Line 877: return;
Line 878: }
Line 883: for (GlusterBrickEntity brick : volumeEntity.getBricks()) {
Line 884: if (brick.getAsyncTask() != null &&
brick.getAsyncTask().getStatus() == JobExecutionStatus.STARTED) {
Line 885: list.add(brick);
Line 886: }
Line 887: }
I have a question here, is it possible that the bricks displayed in [*] will
change?
Line 888:
Line 889: GlusterVolumeRemoveBricksParameters parameter =
Line 890: new
GlusterVolumeRemoveBricksParameters(volumeEntity.getId(), list);
Line 891: model.startProgress(null);
--
To view, visit http://gerrit.ovirt.org/19401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1048150ca4b994766a09d0a4a1b1d33065051c65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
