Mike Kolesnik has submitted this change and it was merged. Change subject: core: Refactor VmDeviceUtils.addImportedDevices() ......................................................................
core: Refactor VmDeviceUtils.addImportedDevices() This method receives unused parameter id which is removed. Also it receives 2 lists that are always initiated to new ArrayList() but their references aren't being kept, so converted to local variables. Change-Id: I31f9d2e89ec961bd689fbfef26a5cf25f09b9f0c --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 3 files changed, 6 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31f9d2e89ec961bd689fbfef26a5cf25f09b9f0c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
