Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Do not create a new db on upgrade ......................................................................
Patch Set 1: > a question: so the only "bad" thing the user did here is to stop the postgres > service, right? i.e., iiuc, if the service was up, we would have tried to do > an upgrade? > so shouldn't the message suggest the user to check his postgres service is up > and running? No. The only bad thing _I_ did was to stop the postgres service. The user could have done many other different things to get the same error message - e.g. change the user/password/db name in postgresql, block access over the network (if it's remote), etc. Of course we can try to analyze the data we have and suggest a good guess as to why we failed to connect to the database. Not sure it should be in this change, though, and not only in the 3.3 branch. -- To view, visit http://gerrit.ovirt.org/19930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia336e951860f6e1a6a829cabf5e6b5e10592089b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
