Yair Zaslavsky has posted comments on this change.
Change subject: engine: support versions for vm propeties
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 155:
VmPropertiesUtils.getInstance().validateVMProperties(DbFacade.getInstance()
please use getVdsGroupDao() - i.e - extract a method for it.
Please run AddVmCommandTest
Line 554:
.get(getParameters().getVm().getvds_group_id())
Same comment as above.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQuery.java
Line 11: private static final String Version3_0 = "3.0";
Use Version.v3_0.toString()
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 168: } else if (!(validationErrors =
VmPropertiesUtils.getInstance().validateVMProperties(DbFacade.getInstance().getVdsGroupDAO().get(getParameters().getVm().getvds_group_id()).getcompatibility_version(),
vmStaticDataFromParams)).isEmpty()) {
See previous comment about extracting to getVdsGroupDao()
Line 279: .getVdsGroupDAO()
Same here
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/QueriesTest.java
Line 84: Assert.assertTrue(properties.get(new Version(3,
0)).contains("sap_agent"));
Use Version.v3_0
--
To view, visit http://gerrit.ovirt.org/3651
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If132148714e37f48ff3fc5c7bd4bdaa97df248dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
