Sergey Gotliv has posted comments on this change. Change subject: core: Remove redundent update of address for device ......................................................................
Patch Set 1: Code-Review-1 VmDevice has 4 properties, updating 3 of them in one place and address in another is confusing. If you want fix it, check if its possible to remove getAddress(). I don't understand why address is treated different than isPlugged or isReadOnly, it doesn't make sense to me. -- To view, visit http://gerrit.ovirt.org/19953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe8e724b8e7e6e4470db910e4e94ce645065c7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
