Omer Frenkel has posted comments on this change. Change subject: setVmTicket, pass user-name and user-id to vdsm ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java Line 20: private String USER_SESSION_KEY = "VdcUser"; looks like this is not needed Line 54: IVdcUser user = SessionDataContainer.getInstance().getUser(getParameters().getSessionId()); you can just use getCurrentUser() .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java Line 52: getUserName(), getUserId().toString()); no need to explicit call toString on getUserId() here, this way its null safe -- To view, visit http://gerrit.ovirt.org/3564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604937a03a55a17d2e10ebdd94ccbd4aa86342a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
