Yair Zaslavsky has posted comments on this change.
Change subject: core, restapi: Add DbGroup
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java
Line 241: if (!user.getGroups().containsKey(groupName)) {
Line 242: DbGroup dbGroup =
DbFacade.getInstance().getDbGroupDao().getByName(groupName);
Line 243: LdapGroup ldapGroup = null;
Line 244: if (dbGroup != null) {
Line 245: ldapGroup = new LdapGroup(dbGroup);
in general these lines of checking if dbGroup is not null or null and creating
ldap group accordingly can maybe move to some helper static method?
Line 246: } else {
Line 247: ldapGroup = new LdapGroup();
Line 248: }
Line 249: user.getGroups().put(groupName, ldapGroup);
--
To view, visit http://gerrit.ovirt.org/17544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1a7146c29eb74f97e10043d65b5a67f1430021
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
