Kanagaraj M has posted comments on this change.
Change subject: webadmin : Rebalance status error messages
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 568: GlusterVolumeTaskStatusEntity rebalanceStatusEntity =
Line 569: (GlusterVolumeTaskStatusEntity) returnValue;
Line 570: if (rebalanceStatusEntity == null) {
Line 571: cModel.stopProgress();
Line 572:
cModel.setMessage(ConstantsManager.getInstance().getMessages().rebalanceStatusConfirmationMessage(volumeEntity.getName()));
Shouldn't the message be "Could not fetch rebalance status of volume
<volName>".
If the entity is null, it doesn't mean the rebalance has not happened at all
Line 573: } else {
Line 574: setConfirmWindow(null);
Line 575: if (getWindow() == null) {
Line 576: VolumeRebalanceStatusModel
rebalanceStatusModel =
--
To view, visit http://gerrit.ovirt.org/19958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8018bf70530e78aaef3d1bfa608c0b0ecf269360
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
