Livnat Peer has posted comments on this change.

Change subject: core: Update to Quartz 2.1
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/FixedDelayJobListener.java
Line 58: 
This is a FIXed delayed Job listener , why do we need to add validation for it 
being FixedDelayedJob?

....................................................
File 
backend/manager/modules/beans/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java
Line 81:                         TimeUnit.MILLISECONDS);
Any reason to keep this comment?

--
To view, visit http://gerrit.ovirt.org/3250
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib86bab5350a01fce9cff02c91c25b35f0d15e7e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to