Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Don't display DCs that imported external network
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3299: public Object Convert(Object source, AsyncQuery
_asyncQuery) {
Line 3300: if (source == null) {
Line 3301: return new HashMap<Network, Set<Guid>>();
Line 3302: }
Line 3303: return source;
Lior, GetAllExternalNetworksOnProviderQuery currently returns List<Network> - I
think we should either create "network to attachedDataCenters" map here, or
adjust GetAllExternalNetworksOnProviderQuery result.
Otherwise, if I'm not mistaken, current code can cause ClassCastException in
ImportNetworksModel during cast
(Map<Network, Set<Guid>>) returnValue
Line 3304: }
Line 3305: };
Line 3306:
Frontend.RunQuery(VdcQueryType.GetAllExternalNetworksOnProvider,
Line 3307: new IdQueryParameters(providerId),
--
To view, visit http://gerrit.ovirt.org/19982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21305c9b21d44c441fc5c6a7d54d162d30ca6248
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
