Sahina Bose has posted comments on this change.
Change subject: restapi: Modified gluster volume rebalance action
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java
Line 86: @Override
Line 87: public Object lookupEntity(Object id) throws
BackendFailureException {
Line 88: GlusterVolumeEntity volume =
doGetEntity(GlusterVolumeEntity.class,
Line 89: query, getQueryParams(queryParamsClass, id),
id.toString());
Line 90: GlusterVolume model = new GlusterVolume();
Can you not call mapper here to populate model?
Line 91: model.setId(volume.getId().toString());
Line 92:
Line 93: Step step = new Step();
Line 94: step.setId(volume.getAsyncTask().getStepId().toString());
--
To view, visit http://gerrit.ovirt.org/18208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
