Vojtech Szocs has uploaded a new change for review. Change subject: webadmin,userportal: Improve LoginModel handling ......................................................................
webadmin,userportal: Improve LoginModel handling 1. LoginModel was originally designed in the spirit of "create new instance each time the login screen is presented". But we handle login models as singletons in our applications. Therefore, after the user signs out, we need to reset (re-enable) login model input fields again. Previously, this was done by the application. After this patch, this is done via LoginModel.resetAfterLogout() method. 2. LoginModel (used by WebAdmin) disables its input fields (username, password, domain, login button) during the login operation. UserPortalLoginModel (used by UserPortal) completely overrides LoginModel's Login() method, and does not comply with the above behavior. For consistency, this behavior was added to UserPortalLoginModel as well. Change-Id: I14fabee5f38c04f6081b0ce1e36deff336653120 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java 4 files changed, 30 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/3672/1 -- To view, visit http://gerrit.ovirt.org/3672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14fabee5f38c04f6081b0ce1e36deff336653120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
