Einav Cohen has posted comments on this change.

Change subject: packaging: setup: Update Default DC compatibility level as 3.1 
in gluster mode
......................................................................


Patch Set 2:

Hi Sahina, thank you for acknowledging my comment.

> Without this, even disabling validation for DC on create cluster is a hack, 
> IMO.

although only disabling validation for DC is not a full solution (therefore, 
may seem as "hacky"), it is still a step in the right direction to my 
understanding. Assuming the New Cluster dialog is going to remain pretty much 
the same, with the same DC-related-validations (for virt purposes), you will 
still need at some point to ignore anything DC-related in that dialog 
(depending on the cluster-type/application-mode). 

I think that for the purpose of solving the bug you can start with that. My 
hunch is that supporting "orphan" clusters is a big task, and there is no 
reason to not do it in several phases. However, I am not a 
packaging/engine-core maintainer, so better make sure with the other reviewers 
of this patch that they are OK with going with this solution 
(@Alon/Allon/Yair?).

-- 
To view, visit http://gerrit.ovirt.org/19185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989755cd72b977e7398049008311a540a13dfb3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to