Lior Vernia has posted comments on this change. Change subject: engine: Modified external networks query ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/dbscripts/storages_sp.sql Line 724: END; $procedure$ Line 725: LANGUAGE plpgsql; Line 726: Line 727: Line 728: CREATE OR REPLACE FUNCTION GetDcIdByExternalNetworkId(v_external_id text) After reading online a little it doesn't seem like there should be any trouble indexing on text, especially since we know the values are gonna be quite short (they only represent external IDs). Either way, I'll add the index as a partial one where the external ID isn't null, so adding normal oVirt networks won't suffer any performance hit. Line 729: RETURNS SETOF UUID STABLE Line 730: AS $procedure$ Line 731: BEGIN Line 732: RETURN QUERY -- To view, visit http://gerrit.ovirt.org/19980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd9d918dabc0930d1801678f405c954d95228003 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
