Omer Frenkel has posted comments on this change. Change subject: engine: Reset Gluster Volume Options ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java Line 35: return super.canDoAction(); if no logic is added why override? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java Line 337: GlusterVolumeResetOptionsFailed(4132), // TODO: Update the error code when this TODO should be addressed? .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties Line 508: please remove this whitespace -- To view, visit http://gerrit.ovirt.org/3662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b86d8be370055170f81e41245cb34c21ebf8c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
