Allon Mureinik has posted comments on this change.
Change subject: engine: Fix findbug error - possible NPE
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 88: for (Entry<Guid, GlusterAsyncTask> entry :
runningTasks.entrySet()) {
Line 89: Guid taskId = entry.getKey();
Line 90: final GlusterAsyncTask task = entry.getValue();
Line 91:
Line 92: List<Step> steps =
getStepDao().getStepsByExternalId(taskId);
steps can never be null here - just remove the steps == null check
Line 93: if (steps == null || steps.isEmpty()) {
Line 94: // the task may have been started from the CLI
Line 95: // need to add job to monitor
Line 96: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 104: }
Line 105: return null;
Line 106: }
Line 107: });
Line 108: } else {
The else block doesn't harm anything, but it does seem a bit redundant.
Line 109: //update status in step table
Line 110: for (Step step: steps) {
Line 111: if (step.getEndTime() != null) {
Line 112: //we have already processed the task
--
To view, visit http://gerrit.ovirt.org/20103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
