Yair Zaslavsky has posted comments on this change.

Change subject: core: nfs mount options validation
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1109:     @DefaultValueAttribute("600")
There is a collision with PosixStorageEnabled.

Line 1110:     NFSMinimalTimeoutSumUnits(350),
Is this going to be used in the code or are u using the constant in the 
validation util?

--
To view, visit http://gerrit.ovirt.org/3670
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fde378547d0ed776db99cb7fffc1a3db052a24b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to