Sandro Bonazzola has posted comments on this change.
Change subject: vdsm: use startMonitoringDomain
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File src/ovirt_hosted_engine_setup/tasks.py
Line 124: acquired = False
Line 125: while not acquired:
Line 126: time.sleep(self.POLLING_INTERVAL)
Line 127: self.logger.debug('Waiting for domain monitor')
Line 128: response = serv.s.getVdsStats()
Maybe, but I prefer to stay near to what Federico suggested and Leonid tested,
so I'll leave it as is for now.
Line 129: self.logger.debug(response)
Line 130: if response['status']['code'] != 0:
Line 131: self.logger.debug(response['status']['message'])
Line 132: raise RuntimeError(_('Error acquiring VDS status'))
--
To view, visit http://gerrit.ovirt.org/19867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3099081b79d461685901a1a32e9d526bd3bb758a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Leonid Natapov <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
