Ori Liel has posted comments on this change.

Change subject: rest: split the hierarchy of BackendUsersResource and 
BackendDomainUsersResource
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendUsersResource.java
Line 8: {
Now that  I look at the class hierarchy, this class is redundant to begin with 
(already before your patch). Please take the opportunity and remove it as well 
(functionality goes into BackendDomainUsersResource). 

thanks

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUsersResourceBase.java
Line 22: }
I think this object doesn't need to exist, the functionality can go inside 
BackendDomainUsersResource

--
To view, visit http://gerrit.ovirt.org/3671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1387f5fc8191e2343bb141b95c8676c24bec2c4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to