Vinzenz Feenstra has uploaded a new change for review. Change subject: [frontend] Add Client IP to VM session tab ......................................................................
[frontend] Add Client IP to VM session tab As per request we're now showing the Client IP in the session tab to indicate the IP of a currently connected user. Change-Id: I021ed69b99cf9d474a1f4d23e83dd12b5e1cf701 Bug-Url: https://bugzilla.redhat.com/1016844 Signed-off-by: Vinzenz Feenstra <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSessionsModel.java 3 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/20186/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index 57ecd4d..644eac2 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -420,6 +420,9 @@ @DefaultStringValue("Console User") String consoleConnectedUserVm(); + @DefaultStringValue("Console Client IP") + String consoleClientIp(); + @DefaultStringValue("Logged-in User") String loggedInUserVm(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java index f5e2167..acaa875 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java @@ -19,13 +19,15 @@ TextBoxLabel guestUserName = new TextBoxLabel(); TextBoxLabel consoleUserName = new TextBoxLabel(); + TextBoxLabel clientIp = new TextBoxLabel(); public VmSessionsModelForm(ModelProvider<VmSessionsModel> modelProvider, CommonApplicationConstants constants) { - super(modelProvider, 2, 1); + super(modelProvider, 3, 1); driver.initialize(this); formBuilder.addFormItem(new FormItem(constants.loggedInUserVm(), guestUserName, 0, 0)); formBuilder.addFormItem(new FormItem(constants.consoleConnectedUserVm(), consoleUserName, 0, 1)); + formBuilder.addFormItem(new FormItem(constants.consoleConnectedClientIp(), clientIp, 0, 1)); } @Override diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSessionsModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSessionsModel.java index 07853c7..eb586e7 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSessionsModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSessionsModel.java @@ -9,6 +9,7 @@ String guestUserName; String consoleUserName; + String clientIp; public VmSessionsModel() { super(); @@ -39,6 +40,7 @@ this.consoleUserName = vm.getConsoleCurentUserName(); this.guestUserName = vm.getGuestCurentUserName(); + this.clientIp = vm.getClientIp(); } public String getGuestUserName() { @@ -57,4 +59,11 @@ this.consoleUserName = consoleUserName; } + public void setClientIp(String clientIp) { + this.clientIp = clientIp; + } + + public String getClientIp() { + return clientIp; + } } -- To view, visit http://gerrit.ovirt.org/20186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I021ed69b99cf9d474a1f4d23e83dd12b5e1cf701 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
