Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Made profile name checks consistent
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 386: boolean profilesValid = true;
Line 387: Iterable<VnicProfileModel> profiles =
getProfiles().getItems();
Line 388: for (VnicProfileModel profileModel : profiles) {
Line 389: if (!profileModel.validate()) {
Line 390: profilesValid = false;
consider adding break;
Line 391: }
Line 392: }
Line 393:
Line 394: return getName().getIsValid() && getVLanTag().getIsValid() &&
getDescription().getIsValid()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
Line 314: return isValid;
Line 315: }
Line 316: for (KeyValueLineModel keyValueLineModel :
(List<KeyValueLineModel>) getKeyValueLines().getItems()) {
Line 317: String key = (String)
keyValueLineModel.getKeys().getSelectedItem();
Line 318: if (key == null || key.equals(NO_KEYS) ||
key.equals(SELECT_KEY)) {
relevant?
Line 319: continue;
Line 320: }
Line 321:
Line 322: keyValueLineModel.getValue().setIsValid(true);
--
To view, visit http://gerrit.ovirt.org/20180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ided5e902faae928608a7558a08ed1768e3d8cb81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
