Michael Pasternak has posted comments on this change. Change subject: cli: update on vm --os-boot does not work as expected(#1012985) ......................................................................
Patch Set 4: (2 comments) .................................................... File src/ovirtcli/command/command.py Line 140: param_period = self.fixParamNameIfParamIsKeyword(param_period) Line 141: if hasattr(obj_params_set_cand, param_period): Line 142: if getattr(obj, props[i]) != None and clearListData: Line 143: setattr(obj, props[i], []) Line 144: clearListData = False ravi did you saw my comment in PS-2? Line 145: if getattr(obj_params_set_cand, param_period) != None: Line 146: getattr(obj, props[i]).append(obj_params_set_cand) Line 147: obj_params_set_cand = params_set_cand.factory() Line 148: root_obj_params_set_cand = obj_params_set_cand Line 160: obj_params_set_cand = param_period_cand_obj Line 161: elif hasattr(obj_params_set_cand, param_period): Line 162: param_period_cand = ParseHelper.getXmlType(param_period) Line 163: if param_period_cand: Line 164: print 'elif hasattr(obj_params_set_cand, param_period):' please remove this ^ Line 165: param_period_cand_obj = getattr(obj_params_set_cand, param_period) Line 166: obj_params_set_cand = param_period_cand_obj Line 167: else: Line 168: self.error(Messages.Error.INVALID_OPTION_SEGMENT % \ -- To view, visit http://gerrit.ovirt.org/20098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc3aa9c42fed2f6fc423e106096f197ef4be3819 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
