Allon Mureinik has posted comments on this change. Change subject: core: adding db configuration file ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Basically looks good, but I'm not sure how this script would actually be run. Please elaborate? .................................................... File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql Line 451: All this values were added previously in this script. if they're deprecated, consider not adding them. -- To view, visit http://gerrit.ovirt.org/3689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic55f7ce8d7c3cf595f6793e8e801773ccfeea95f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
