Allon Mureinik has posted comments on this change. Change subject: core: cleanup old configuration modifications from DB and FS ......................................................................
Patch Set 3: I like everything you did here, but please take a look at the following scripts, I think you may have missed a few: upgrade_domain_entries_03_00_0200: This has complex logic on top of vdc_options. Should it be merged into config.sql 03_00_0250_update_BootstrapUrl_vdc_options.sql: was merged into config.sql too in the previous path if I'm not mistaken, should be removed. 03_00_0310_upgrade_remove_default_security_auth.sql: was merged into config.sql too in the previous path if I'm not mistaken, should be removed. 03_00_0420_config_json.sql: updates vdc_options in a non standard way, should be standardized and merged into config.sql 03_00_0500_modify_AsyncTaskZombieTaskLifeInMinutes.sql: was merged into config.sql too in the previous path if I'm not mistaken, should be removed. 03_01_0400_remove_ImagesSyncronizationTimeout_config_value.sql: was merged into config.sql too in the previous path if I'm not mistaken, should be removed. 03_01_0900_SendVmTicketUID.sql: updates config, should also be removed and merged into config.sql -- To view, visit http://gerrit.ovirt.org/3692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ebe18db6b2ab301b894fce681bfeebbe0a87077 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
