Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fix problems in engine-backup.sh
......................................................................
Patch Set 2: -Code-Review
(3 comments)
Few comments
....................................................
File packaging/bin/engine-backup.sh
Line 208: verifyConnection
Line 209: log "Restoring database backup at
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 210: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 211: output "Starting services:"
Line 212: service ovirt-engine start
Should we fail if this doesn't work?
Line 213: service httpd restart
Line 214: output "Note: you might need to manually fix iptables/firewalld
conf and autostart of ovirt-engine service"
Line 215: }
Line 216:
Line 209: log "Restoring database backup at
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 210: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 211: output "Starting services:"
Line 212: service ovirt-engine start
Line 213: service httpd restart
same
Line 214: output "Note: you might need to manually fix iptables/firewalld
conf and autostart of ovirt-engine service"
Line 215: }
Line 216:
Line 217: verifyConnection() {
Line 254: if ! [ -e "${backup}" ]; then
Line 255: echo "Skipping not-existent ${path}"
Line 256: else
Line 257: cp -a "${backup}" "${dirname}" || logdie
"Cannot copy '${backup}' to '${dirname}'"
Line 258: selinuxenabled && restorecon -R "${path}"
|| logdie?
Line 259: fi
Line 260: done || logdie "Cannot read ${paths}"
Line 261: }
Line 262:
--
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
