Greg Padgett has posted comments on this change. Change subject: client: throw only HA-specific exceptions from client library ......................................................................
Patch Set 1: Verified+1 Sandro, Martin: in light of comments [1] on the vdsm patch to integrate the client score API into vdsm suggesting that specific exceptions be caught, what do you think of something like this? The goal is to prevent a runtime error in the client/broker from causing vdsm to crash, and I don't know specifically which exceptions may be thrown. This would normalize them so a client could easily protect itself against errors in the ha system. [1] http://gerrit.ovirt.org/#/c/20126/4/vdsm/API.py -- To view, visit http://gerrit.ovirt.org/20307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I276ea8d5f684be53f174afa0b3c9f70ed377d1a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
