Mike Kolesnik has posted comments on this change.
Change subject: core: Filtering PermissionDAO.getAllForEntity
......................................................................
Patch Set 2: (2 inline comments)
Some comments..
I would also prefer that unrelated refactoring would've been done in different
patches, and not all crammed to one.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAO.java
Line 123: List<permissions> getAllForEntity(Guid id, Guid userID, boolean
isFiltered);
No javadoc?
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDAOTest.java
Line 252: private static void assertGetllForEntityResult(List<permissions>
result) {
I think you meant: ssertGet[A]llForEntityResult
--
To view, visit http://gerrit.ovirt.org/3658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I728863b5ff14b3b0937a32cf41c623794539647d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
