anmolbabu has posted comments on this change.
Change subject: webadmin : gluster volume rebalance status error handling
......................................................................
Patch Set 13:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 584: public void onSuccess(Object model, Object returnValue) {
Line 585: cModel.stopProgress();
Line 586: GlusterVolumeTaskStatusEntity rebalanceStatusEntity =
Line 587: (GlusterVolumeTaskStatusEntity)
((VdcQueryReturnValue) returnValue).getReturnValue();
Line 588: if (rebalanceStatusEntity == null) {
bcoz it is anyway null right if its not succeded? otherwise should i replace it
with getsucceeded?
Line 589: cModel.setMessage(ConstantsManager.getInstance()
Line 590: .getMessages()
Line 591:
.rebalanceStatusFailed(volumeEntity.getName()));
Line 592: } else {
--
To view, visit http://gerrit.ovirt.org/19598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13748716f23a797fc0e3ec16acbb4150c43b7e8
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
